Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove a data race by compiling the exclude regexes in the preprocess phase instead #677

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove a data race by compiling the exclude regexes in the preprocess phase instead #677

wants to merge 1 commit into from
+13 −10

Commits on Nov 2, 2024

  1. remove a data race by compiling the exclude regexes in the preprocess… 

    … phase

the regex compilation was done lazily on first access but did not properly synchronize
for being accessed by multiple watcher goroutines

between the option of adding a mutex for something that (should) only ever happen
once and removing the potential for a race, this seems like the better choice
    @istyf
    istyf committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    e7d1cdd View commit details
    Browse the repository at this point in the history