You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current implementation:
Returns the address by retrieving the public key from first 32 bytes of the signature. This ignores the signature verification completely.
Expected implementation:
Return the address of the signer only if the signature is verified for the given message.
Note: Also, this function name should be edverify.
The text was updated successfully, but these errors were encountered:
Confirm the claim that there is a missing implementation for ecrecover.
For web3 implementation, ecrecover has been used in the context of secp256k1 curve and must be separated from edverify for ed25519 signature verification which is primarily used by Aion.
Web3 version:
aion-web3 v1.2.6-beta.0
Implementation issue of
recover
function https://github.com/aionnetwork/aion_web3/blob/v1.1/packages/web3-eth-accounts/src/index.js#L316Current implementation:
Returns the address by retrieving the public key from first 32 bytes of the signature. This ignores the signature verification completely.
Expected implementation:
Return the address of the signer only if the signature is verified for the given message.
Note: Also, this function name should be
edverify
.The text was updated successfully, but these errors were encountered: