Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger Refactor #655

Open
qoire opened this issue Oct 1, 2018 · 0 comments
Open

Logger Refactor #655

qoire opened this issue Oct 1, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@qoire
Copy link
Contributor

qoire commented Oct 1, 2018

logback.xml and logback in general provides excellent facilities for doing a variety of things users might want from a logging perspective. For example, for one of our internal projects:

  • We block logging from certain modules, and certain class paths
  • We direct logging output to multiple appenders (ex. Email, Database, Log)
  • We modifying the format of output we get
  • We override default logging with our own logback.xml file easily.

These are features that will let the (experienced) user self-diagnose their system, as well as integrate with any production pipelines that they might have, currently we do this from an OS level but logback can do the same thing for us (and better!).

I would strongly recommend:

  • Refactoring our current logging facilities and tie it directly with an implementation.
  • Reduce the awkwardness of how we initialize our logging, currently it's done via a convoluted static initialization process.
  • Rethink how we separate between different loggers. (For example, class tied to VM or GENERAL might be very noisy, if we give it some identifier, we can disable it individually.)

Also: if someone is working on loggers for production, we might want to consider include #651 as a dependency.

@qoire qoire added the enhancement New feature or request label Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant