Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for address fail to differentiate wrapping #398

Open
fulldecent opened this issue Jul 12, 2019 · 2 comments
Open

Tests for address fail to differentiate wrapping #398

fulldecent opened this issue Jul 12, 2019 · 2 comments

Comments

@fulldecent
Copy link
Contributor

The tests for wrapping are identical to the tests for not wrapping

@jeff-aion
Copy link
Contributor

I don't understand this issue. What do you mean by "wrapping"?

That test is just verifying a zero address (an internal type) has a correct .equals() implementation and agrees with a constant we use through some tests. Really, the test is probably redundant now that these types are implemented elsewhere (they used to be AVM-resident).

@fulldecent
Copy link
Contributor Author

I was just reviewing the code and am pointing out duplicate code in the test. The same assertions are used across different tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants