Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store per-DApp reflection caches long-lived #284

Open
aionbot opened this issue Dec 5, 2018 · 2 comments
Open

Store per-DApp reflection caches long-lived #284

aionbot opened this issue Dec 5, 2018 · 2 comments
Labels
Performance Measure/Improve performance

Comments

@aionbot
Copy link

aionbot commented Dec 5, 2018

Issue created by jeff-aion (on Wednesday Oct 17, 2018 at 20:21 GMT)

Profiling while the hot DApp cache is active still resulted in reflection operations rising to the top. These cases seemed to be due to ReflectionStructureCodec (when looking up constructors for stub instantiation, mostly) and ABIDecoder (when looking through method listings).

As these are only observable in relatively simple DApps, in the hot cache, and likely heavily JITted, this isn't a high priority but it is some relatively low-hanging fruit.

@aionbot
Copy link
Author

aionbot commented Dec 5, 2018

Comment by jeff-aion (on Monday Nov 19, 2018 at 14:43 GMT)

This is purely a performance item, and depends on #285, so it can be done fairly late. That said, we should probably implement this sometime within the Beta timeframe since it should be considered within any performance analysis we do, leading up to TestNet.

@aionbot
Copy link
Author

aionbot commented Dec 5, 2018

Comment by jeff-aion (on Thursday Nov 29, 2018 at 19:46 GMT)

Moving to Future since this is low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Measure/Improve performance
Projects
None yet
Development

No branches or pull requests

2 participants