Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significantly speed up parsing netloc in URL objects #1112

Merged
merged 33 commits into from
Sep 6, 2024

use PyIsTrue

02e72be
Select commit
Loading
Failed to load commit list.
Merged

Significantly speed up parsing netloc in URL objects #1112

use PyIsTrue
02e72be
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 6, 2024 in 0s

95.08% (target 100.00%)

View this Pull Request on Codecov

95.08% (target 100.00%)

Details

Codecov Report

Attention: Patch coverage is 96.89922% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.08%. Comparing base (926b9dc) to head (02e72be).

Files with missing lines Patch % Lines
yarl/_url.py 94.52% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
+ Coverage   95.06%   95.08%   +0.02%     
==========================================
  Files          30       30              
  Lines        4497     4600     +103     
  Branches      396      410      +14     
==========================================
+ Hits         4275     4374      +99     
- Misses        196      200       +4     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.