Only construct the allowed_methods set once for a StaticResource
#9911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
added
bot:chronographer:skip
bdraco
commented
Nov 15, 2024
bdraco
changed the title
allowed_methods set once for a StaticResourceallowed_methods set once for a StaticResource
CodSpeed Performance ReportMerging #9911 will not alter performanceComparing Summary
|
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9912 🤖 @patchback |
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #9913 🤖 @patchback |
bdraco
added a commit
that referenced
this pull request
Nov 15, 2024
…s` `set` once for a `StaticResource` (#9912) Co-authored-by: J. Nick Koston <[email protected]>
bdraco
added a commit
that referenced
this pull request
Nov 15, 2024
…s` `set` once for a `StaticResource` (#9913) Co-authored-by: J. Nick Koston <[email protected]>
|
Going to have to revert this since |
bdraco
added a commit
that referenced
this pull request
Nov 19, 2024
#9911 optimized this to only build the set once, however ``aiohttp-cors`` relies on being able to mutate this at runtime https://github.com/aio-libs/aiohttp-cors/blob/38c6c17bffc805e46baccd7be1b4fd8c69d95dc3/aiohttp_cors/urldispatcher_router_adapter.py#L187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed in #9899 (comment)
Likely to have minimal performance improvement besides saving some memory churn so I didn't call it in out the changelog