Rethink qp.PDF.limits

[johannct]

qp/qp/pdf.py

Line 89 in 7a43a8f

self.limits = (min(self.limits[0], np.min(self.gridded[0])), max(self.limits[-1], np.max(self.gridded[0])))

As limits attribute is provided on top of the grid tuple, I would expect that it means that limits takes over precedence over the grid boundaries. so the lower bound should be the max(grid.min, limits[0]) and the upper bound should be min(grid.max, limits[1])

[aimalz]

The code is written as I originally intended (it's not a "bug" in the sense of an accident), but I think you're right that it probably shouldn't be that way (not being a bug doesn't make it not a mistake). I did think the notion of PDF-wide "limits" was problematic so circumvented it in the upcoming refactored version. I'll leave this issue open as a reminder, though I'm going to rename it for the sake of context. Thanks for your patience with this.