Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude certain URLs from checking #276

Open
rdmueller opened this issue May 30, 2019 · 4 comments
Open

exclude certain URLs from checking #276

rdmueller opened this issue May 30, 2019 · 4 comments
Assignees
Labels
enhancement hacktoberfest This is a nice ticket for the hacktoberfest help-needed

Comments

@rdmueller
Copy link
Collaborator

in the same way in which I can configure which http codes are failure, warning and success, I would like to configure a list of URLs which are excluded from the http check:
(maybe as regexp)

httpExcludeURLs = [ '(http|https)://example.com.*']
@rdmueller
Copy link
Collaborator Author

I just noticed that there is already some kind of configuration for this

final static String ITEM_NAME_urlsToExclude = "urlsToExclude"

but I can't find any implementation...

@Prankurtiwari
Copy link
Contributor

Hi @ascheman I would like to work on this bug too, please assign this to me and let me know in case of any update update.

@ascheman
Copy link
Member

@Prankurtiwari : The configuration has moved to htmlSanityCheck-core/src/main/java/org/aim42/htmlsanitycheck/Configuration.java as we switched from Groovy to Java meanwhile for the implementation of the core module.

@ascheman
Copy link
Member

Perhaps @rdmueller could help elaborate on this?

Per my understanding, the Configuration should be extended by a Set<String> of URLs to ignore, for example as they require credentials. Perhaps it would make sense to enable some sort of pattern matching (regular expression) to allow to ignore a more or less large subset of URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hacktoberfest This is a nice ticket for the hacktoberfest help-needed
Projects
None yet
Development

No branches or pull requests

3 participants