Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSS] Allow arbitrary urls in embed_image and embed_thumbnail #215

Open
Griefed opened this issue Mar 11, 2021 · 7 comments
Open

[RSS] Allow arbitrary urls in embed_image and embed_thumbnail #215

Griefed opened this issue Mar 11, 2021 · 7 comments

Comments

@Griefed
Copy link

Griefed commented Mar 11, 2021

Heya,

if possible, I would like some documentation/explanation on how the !rss embed image and !rss embed thumbnail commands are to be used in order to add an image to the embed. I'm having trouble setting it to an image so it is included in the message.

What do I need to do in order to add an image/thumbnail to the rss message? After setting !rss embed image <image_url.png> rss tells me that the new tag is available as $<image_url.png> but when adding that to the template, the image isn't displayed.

What am I not understanding here? :D

Cheers,
Griefed

@Griefed
Copy link
Author

Griefed commented Mar 11, 2021

Trying to replace a bot by configuring rss so I can have one less bot on my discord server. Here's an example. Top is what I want to imitate, bottom is the current configuration, where I want to insert embed_image and embed_thumbnail.
image

@aikaterna
Copy link
Owner

I'll have to change how the cog responds to users when adding a tag - naked image urls are not allowed, you must use a tag that is included with the feed, under rss listtags. Usually images can be found under tags like $content_image01 or other sequental content_image numbers if they are present. Multiple people have asked for settable urls instead of tags so I will consider it and close this issue when I have it resolved or if I decide not to support it.

@Griefed
Copy link
Author

Griefed commented Mar 11, 2021

Thanks for getting back to me. Sounds great. Being able to set tags manually would be a dream come true, as it would allow one to setup templates much like the example above.
listtags doesn't include any images, sadly. That's why I was hoping I could set images with embed_image and embed_thumbnail.

Keep up the good work. Stay safe and take care.

@aikaterna
Copy link
Owner

The RSS feed itself does not contain any images if you don't have a $content_image01 tag or similar. If this is your feed, you may want to add those. They are scraped from html tags styled <img src= ... >.

@aikaterna aikaterna changed the title [RSS] Documentation regarding embed_image and embed_thumbnail [RSS] Allow arbitrary urls in embed_image and embed_thumbnail Mar 11, 2021
@aikaterna
Copy link
Owner

608bcae catches your incorrect input and will explain the situation a bit better.

@Griefed
Copy link
Author

Griefed commented Mar 12, 2021

Sweet, thanks!
It appears the problem is on my end. Wordpress' feed doesn't include images, or rather, none that can be used by RSS. The list of available tags for my feed doesn't mention any image whatsoever, so I will have to check whether I can somehow expand my feed with said images, in order for RSS to work with them.
Will need to check whether there's something I can do from my end to provide images. A plugin or something.

@aikaterna
Copy link
Owner

I still want to work on allowing arbitrary urls but since I designed RSS to use tags this will take me a bit. The commit with more chatter regarding the input is a stopgap until I have time to figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants