Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use error codes in the parser rather than just outputting human-readable strings #90

Open
2 tasks
giovannipizzi opened this issue Mar 5, 2020 · 3 comments

Comments

@giovannipizzi
Copy link
Member

At the moment, warnings that are detected are simply added as human-readable strings into a 'warnings' list in the parsed output.

Task:

  • define which error codes we want to have (this can be done in this issue)
  • implement these
@greschd
Copy link
Member

greschd commented Mar 5, 2020

@giovannipizzi, is the intent to change this before the 2.0 release, or after?

@giovannipizzi
Copy link
Member Author

I would has said after, but since 2.0 is out, this is now obvious ;-)

I think we can drop py2 support and move on, and do additional improvements for the upcoming release (we needed to have something working with AiiDA 1.0 and both python versions so people in AiiDA 1.0 can use it).

@greschd
Copy link
Member

greschd commented Aug 13, 2020

When adding more exit codes, I think it makes sense to follow a convention similar (or equal) to aiidateam/aiida-quantumespresso#296 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants