Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To make sure if cache method in FcPath is functioning as it supposed to do. #41

Open
khsrali opened this issue Jul 15, 2024 · 0 comments

Comments

@khsrali
Copy link
Contributor

khsrali commented Jul 15, 2024

Previously, when FcPath was part of aiida-firecrest @chrisjsewell could control explicitly if cache should be enable or disable based on specific purpose, in this way: self._cwd.joinpath(remotesource).enable_cache()

But when the class eth-cscs/pyfirecrest#43 got merged into pyfirecrest, they took enable_cache() away, in such a way that when you make a joinpath() the new path is just copying the flag from the original path. So here if self._cwd has cache=True then joinpath() returns an FCPath with cache=True, likewise for cache=False.

For now we have self._cwd with cache=True always. The thing that I'm not entirely sure if that is going to mess things up when files on remote is changed...
In my manual tests, I haven't seen any wrong return when files on remote has changed and yet cache=True.

But still this has to be investigated thoroughly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant