Cast job_id to str to conform with type of _jobs_cache #6543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unkcpz
force-pushed
the
fix/6542/cast-job-id-to-str-in-update-job-info
branch
from
780017c
to
ce3b1ee
Compare
unkcpz
force-pushed
the
fix/6542/cast-job-id-to-str-in-update-job-info
branch
from
ce3b1ee
to
5d96167
Compare
|
TBH, I am very confusing here. I give up on this fix can not get my head right with these types. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6543 +/- ##
==========================================
+ Coverage 77.51% 77.82% +0.31%
==========================================
Files 560 564 +4
Lines 41444 41926 +482
==========================================
+ Hits 32120 32623 +503
+ Misses 9324 9303 -21 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6542
As @sphuber pointed out in aiidateam/aiida-hyperqueue#30 (comment), this is only a workaround. The ultimate solution should be using dataclass for
JobInfo.