-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test the performance of atomistic.StructureData
vs orm.StructureData
#7
Comments
Hi @giovannipizzi, I did some test on the creation of orm and atomistic StructureData, increasing the number of atoms and also the number of properties in the atomistic. These are the results: Just to underline that here I do not define kinds by default, but only if explicitly provided. I think it should be up to the user to provide the correct kinds and related properties. |
So the new is much faster, right? Great! Regarding the kinds, this means you didn't test yet what we discussed yesterday, that is that kinds are always computed and stored in the attributes/properties? But this is still planned right? Good to retest after, as the search for uniqueness could be slow if not implemented optimally |
Yes, for now I do not have any automatic kinds assignation nor check for uniqueness. |
test if the new
StructureData
is slower than the original one.The text was updated successfully, but these errors were encountered: