Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AiiDA core 2.0 #240

Closed
7 of 8 tasks
ltalirz opened this issue Feb 24, 2022 · 8 comments · Fixed by #254
Closed
7 of 8 tasks

Support AiiDA core 2.0 #240

ltalirz opened this issue Feb 24, 2022 · 8 comments · Fixed by #254
Assignees
Milestone

Comments

@ltalirz
Copy link
Member

ltalirz commented Feb 24, 2022

Given that aiida-dynamic-workflows is already based on the aiida-core develop branch, I'm finding myself in need of an AiiDAlab environment that supports AiiDA 2.0.

I'll have a quick stab at updating the Dockerfile and will be pushing this to a separate aiida-2 branch.
We can use this issue to keep track of other packages that need updating

Follow-up item after completion: aiidalab/aiidalab-launch#119

Edited by @csadorf.

@csadorf
Copy link
Member

csadorf commented Feb 25, 2022

@ltalirz Thanks for taking the initiative. I am going to assign you for now since you already started working on this, but please feel free to tab me in for any of these tasks.

@csadorf csadorf changed the title new branch for aiida-core 2.0 support Support AiiDA core 2.0 Feb 25, 2022
@ltalirz
Copy link
Member Author

ltalirz commented Feb 28, 2022

cheers; the aiida-2 branch now exists and I'm using it #241
Feel free to use this branch as well and make further updates/improvements

I think you can move ahead with merging aiidalab/aiidalab#269 and aiidalab/aiidalab-eln#34

@csadorf csadorf linked a pull request Jun 20, 2022 that will close this issue
@csadorf
Copy link
Member

csadorf commented Jul 26, 2022

Note: This effort is currently blocked, because the latest aiidateam/aiida-core image is based on the latest aiidateam/prerequisites images that use a newer PostgreSQL version which – without migration – will break existing user installations.

See also: #25

@ltalirz
Copy link
Member Author

ltalirz commented Jul 26, 2022

If you feel that this is the main issue holding you back and migration is too difficult, you can also downgrade postgres (the main reason for the postgres upgrade was to upgrade the OS).

However, if you do migrate, and postgres upgrades are so disruptive, then perhaps consider going to ubuntu 22.04 and postgres 14.

@csadorf
Copy link
Member

csadorf commented Jul 26, 2022

If you feel that this is the main issue holding you back and migration is too difficult, you can also downgrade postgres (the main reason for the postgres upgrade was to upgrade the OS).

Yes, thank you for the suggestion. We have already decided (in today's dev meeting) to downgrade and slightly postpone the migration to unblock this issue.

@csadorf csadorf assigned csadorf and unassigned yakutovicha Jul 27, 2022
@csadorf csadorf linked a pull request Jul 27, 2022 that will close this issue
5 tasks
@csadorf csadorf modified the milestone: v22.08.0 Jul 28, 2022
@unkcpz
Copy link
Member

unkcpz commented Jul 31, 2022

After this is done, I think most apps in app store would incompatible since they are specifically set to dependent on aiida-core~=1.0. We need to disallow the user to install the old versions of these apps until they have aiida-core 2.0 supported.

@csadorf
Copy link
Member

csadorf commented Aug 4, 2022

After this is done, I think most apps in app store would incompatible since they are specifically set to dependent on aiida-core~=1.0. We need to disallow the user to install the old versions of these apps until they have aiida-core 2.0 supported.

@unkcpz We could modify the is_comaptible() function too look at the constraints instead of the current environment.

@unkcpz
Copy link
Member

unkcpz commented Oct 19, 2022

@unkcpz We could modify the is_comaptible() function too look at the constraints instead of the current environment.

I open an issue for the compatible check in aiidalab aiidalab/aiidalab#318. So this issue can be closed I think.

@unkcpz unkcpz closed this as completed Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment