Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network ends in infinite loop if no message is received #405

Open
jot2re opened this issue Nov 21, 2022 · 1 comment
Open

Network ends in infinite loop if no message is received #405

jot2re opened this issue Nov 21, 2022 · 1 comment

Comments

@jot2re
Copy link
Collaborator

jot2re commented Nov 21, 2022

Currently the functionality of SockerNetwork.receive is to to continue in an infinite loop if nothing is received. There should be a timeout. This will help in debugging when running interactive applications, as it is otherwise hard to figure out which thread stalls and where.

@jot2re
Copy link
Collaborator Author

jot2re commented Nov 21, 2022

But be aware that the timeout should probably not be too small, since it will be the maximum time that can pass between starting different servers in a real execution.
I think the best compromise is actually to make the SocketNetwork time out relatively fast and instead have a loop in actual applications that handles such timeouts gracefully. But this require finding the current places in the code that allows running decentralised applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant