Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sorting for edge case of match-all #92

Open
htdinh opened this issue May 19, 2017 · 0 comments
Open

Improve sorting for edge case of match-all #92

htdinh opened this issue May 19, 2017 · 0 comments

Comments

@htdinh
Copy link
Contributor

htdinh commented May 19, 2017 •
edited
Loading

The issue is described in comment. The desired sorting should be following. The soft-rule, suggested by @kirsle , is only by the number of words that aren't wildcards, because that's usually the more useful thing when trying to order triggers by "most specific first" ordering

+ [*] text [*]
- match with text
+ [*]
- match all 1
+ *
- match all 2
htdinh pushed a commit to htdinh/rivescript-python that referenced this issue May 19, 2017
aichaos#92 Add special handling for [*]
ecfeb9a
htdinh pushed a commit to htdinh/rivescript-python that referenced this issue May 19, 2017
aichaos#92 Supplement unit test for sorting to include more match-all…
0609226 
… cases
kirsle added a commit that referenced this issue May 19, 2017
@kirsle
Merge pull request #93 from Dinh-Hung-Tu/#92
2d72a33 
#92 Special handle for the case "[*]"
@htdinh htdinh mentioned this issue May 22, 2017
Merged
@htdinh htdinh mentioned this issue May 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@htdinh