Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Math in Typescript for easeOutCirc #165

Open
BOLL7708 opened this issue Nov 9, 2022 · 2 comments
Open

Missing Math in Typescript for easeOutCirc #165

BOLL7708 opened this issue Nov 9, 2022 · 2 comments

Comments

@BOLL7708
Copy link

BOLL7708 commented Nov 9, 2022

I just integrated all the TypeScript functions into a class, and noticed that for easeOutCirc throws an error for sqrt, as it should be Math.sqrt. Super small issue, but might be nice to fix 😅
@gosolivs
Copy link
Collaborator

gosolivs commented Nov 9, 2022

I think It is a cool PR for the first contribution. Can you fix this problem?

@internot169 internot169 mentioned this issue Apr 28, 2023
Merged
@internot169
Copy link
Contributor

Fixed this with #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gosolivs @BOLL7708 @internot169