Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider introducing proper static verification of merge buffer nodes, but "in the right direction" #288

Open
lukstafi opened this issue Oct 11, 2024 · 0 comments
Labels
enhancement Priority below unlabeled
Milestone

Comments

@lukstafi
Copy link
Collaborator

device_to_device ~into_merge_buffer:not_No ~dst ~src used to verify its merge buffer node by requiring that dst is the context coming from linking the code consuming the merge buffer. This is half-static in that the dependency between "producing" and "consuming" the merge buffers is directly expressed in the source. But it goes against the typical uses of context chaining where routines executed later link to contexts of routines executed earlier. Moreover, we verify merge buffers dynamically, so I removed this half-static verification.

But if we convert device_to_device to returning a routine rather than directly scheduling the copying (or "streaming" e.g. aliasing), we can introduce proper static verification of merge buffer nodes. The device_to_device's context would be linked with the code consuming the merge buffer.

@lukstafi lukstafi added the enhancement Priority below unlabeled label Oct 11, 2024
@lukstafi lukstafi added this to the v0.7 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Priority below unlabeled
Projects
None yet
Development

No branches or pull requests

1 participant