From 6b21a122401e97234c36728e68b3cb05db861dfe Mon Sep 17 00:00:00 2001 From: Hamza Date: Fri, 12 Jan 2024 18:17:40 +0100 Subject: [PATCH] update default build-tools version to 33.0.0 --- README.md | 6 +++--- lib/signing.js | 2 +- src/signing.ts | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 1c52105a8..6c22bfe16 100644 --- a/README.md +++ b/README.md @@ -33,7 +33,7 @@ Then copy the contents of the `.txt` file to your GH secrets ## ENV: `BUILD_TOOLS_VERSION` -**Optional:** You can manually specify a version of build-tools to use. We use `29.0.3` by default. +**Optional:** You can manually specify a version of build-tools to use. We use `34.0.0` by default. ## Outputs @@ -68,8 +68,8 @@ steps: keyStorePassword: ${{ secrets.KEY_STORE_PASSWORD }} keyPassword: ${{ secrets.KEY_PASSWORD }} env: - # override default build-tools version (29.0.3) -- optional - BUILD_TOOLS_VERSION: "30.0.2" + # override default build-tools version (33.0.0) -- optional + BUILD_TOOLS_VERSION: "34.0.0" # Example use of `signedReleaseFile` output -- not needed - uses: actions/upload-artifact@v2 diff --git a/lib/signing.js b/lib/signing.js index be7897e0e..06d9481a2 100644 --- a/lib/signing.js +++ b/lib/signing.js @@ -38,7 +38,7 @@ function signApkFile(apkFile, signingKeyFile, alias, keyStorePassword, keyPasswo return __awaiter(this, void 0, void 0, function* () { core.debug("Zipaligning APK file"); // Find zipalign executable - const buildToolsVersion = process.env.BUILD_TOOLS_VERSION || '29.0.3'; + const buildToolsVersion = process.env.BUILD_TOOLS_VERSION || '33.0.0'; const androidHome = process.env.ANDROID_HOME; const buildTools = path.join(androidHome, `build-tools/${buildToolsVersion}`); if (!fs.existsSync(buildTools)) { diff --git a/src/signing.ts b/src/signing.ts index 4232cf3c2..2ddb3e251 100644 --- a/src/signing.ts +++ b/src/signing.ts @@ -15,7 +15,7 @@ export async function signApkFile( core.debug("Zipaligning APK file"); // Find zipalign executable - const buildToolsVersion = process.env.BUILD_TOOLS_VERSION || '29.0.3'; + const buildToolsVersion = process.env.BUILD_TOOLS_VERSION || '33.0.0'; const androidHome = process.env.ANDROID_HOME; const buildTools = path.join(androidHome!, `build-tools/${buildToolsVersion}`); if (!fs.existsSync(buildTools)) {