From 67f47bf1494fabf4d6fa4fa2be8a4f9e00d0b84a Mon Sep 17 00:00:00 2001
From: Ahmed Awan <qe66653@umbc.edu>
Date: Tue, 10 Dec 2024 11:08:34 -0600
Subject: [PATCH] fix prop provided to wrong component, removing redundant
 loading span
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
---
 .../WorkflowInvocationMetrics.vue                        | 4 ++--
 .../WorkflowInvocationState/WorkflowInvocationState.vue  | 9 ++-------
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/client/src/components/WorkflowInvocationState/WorkflowInvocationMetrics.vue b/client/src/components/WorkflowInvocationState/WorkflowInvocationMetrics.vue
index f1b74f006b29..ff06ca1adf7d 100644
--- a/client/src/components/WorkflowInvocationState/WorkflowInvocationMetrics.vue
+++ b/client/src/components/WorkflowInvocationState/WorkflowInvocationMetrics.vue
@@ -15,7 +15,7 @@ const VegaWrapper = () => import("./VegaWrapper.vue");
 
 interface Props {
     invocationId: string;
-    terminal?: boolean;
+    notTerminal?: boolean;
 }
 const props = defineProps<Props>();
 
@@ -384,7 +384,7 @@ const groupByInTitles = computed(() => {
 
 <template>
     <div>
-        <BAlert v-if="!props.terminal" variant="warning" show>
+        <BAlert v-if="props.notTerminal" variant="warning" show>
             <LoadingSpan message="Metrics will update and change as the workflow progresses." />
         </BAlert>
         <BContainer>
diff --git a/client/src/components/WorkflowInvocationState/WorkflowInvocationState.vue b/client/src/components/WorkflowInvocationState/WorkflowInvocationState.vue
index 5904de674543..facd043fdffd 100644
--- a/client/src/components/WorkflowInvocationState/WorkflowInvocationState.vue
+++ b/client/src/components/WorkflowInvocationState/WorkflowInvocationState.vue
@@ -360,16 +360,11 @@ async function onCancel() {
                     </BBadge>
                 </template>
                 <div v-if="invocationAndJobTerminal">
-                    <WorkflowInvocationExportOptions
-                        :invocation-id="invocation.id"
-                        :terminal="invocationAndJobTerminal" />
+                    <WorkflowInvocationExportOptions :invocation-id="invocation.id" />
                 </div>
-                <BAlert v-else variant="info" show>
-                    <LoadingSpan message="Waiting to complete invocation" />
-                </BAlert>
             </BTab>
             <BTab title="Metrics" :lazy="true">
-                <WorkflowInvocationMetrics :invocation-id="invocation.id"></WorkflowInvocationMetrics>
+                <WorkflowInvocationMetrics :invocation-id="invocation.id" :not-terminal="!invocationAndJobTerminal" />
             </BTab>
             <template v-slot:tabs-end>
                 <BButton