From 4f0f75309764e405d9d9991b22b8c7c584cc6df2 Mon Sep 17 00:00:00 2001
From: Ahmed Awan <qe66653@umbc.edu>
Date: Thu, 28 Mar 2024 13:40:59 -0500
Subject: [PATCH] set tool search worker to `null` to remove references while
 unmounted

---
 client/src/components/Panels/Common/ToolSearch.vue | 11 +++++++++--
 client/src/stores/toolStore.ts                     |  5 -----
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/client/src/components/Panels/Common/ToolSearch.vue b/client/src/components/Panels/Common/ToolSearch.vue
index b704cf203d50..31592c803dc9 100644
--- a/client/src/components/Panels/Common/ToolSearch.vue
+++ b/client/src/components/Panels/Common/ToolSearch.vue
@@ -1,7 +1,7 @@
 <script setup lang="ts">
 import { BAlert } from "bootstrap-vue";
 import { storeToRefs } from "pinia";
-import { computed, type ComputedRef, onMounted, type PropType, watch } from "vue";
+import { computed, type ComputedRef, onMounted, onUnmounted, type PropType, watch } from "vue";
 import { useRouter } from "vue-router/composables";
 
 import { type Tool, type ToolSection, useToolStore } from "@/stores/toolStore";
@@ -124,7 +124,7 @@ onMounted(() => {
     if (!searchWorker.value) {
         searchWorker.value = new Worker(new URL("components/Panels/toolSearch.worker.js", import.meta.url));
     }
-    searchWorker.value!.onmessage = ({ data }) => {
+    searchWorker.value.onmessage = ({ data }) => {
         const { type, payload, sectioned, query, closestTerm } = data;
         if (type === "searchToolsByKeysResult" && query === props.query) {
             emit("onResults", payload, sectioned, closestTerm);
@@ -136,6 +136,13 @@ onMounted(() => {
     };
 });
 
+onUnmounted(() => {
+    // The worker is not terminated but it will not be listening to messages
+    if (searchWorker.value?.onmessage) {
+        searchWorker.value.onmessage = null;
+    }
+});
+
 watch(
     () => currentFavorites.value.tools,
     () => {
diff --git a/client/src/stores/toolStore.ts b/client/src/stores/toolStore.ts
index f53cd85b5097..9d29b5ce7b00 100644
--- a/client/src/stores/toolStore.ts
+++ b/client/src/stores/toolStore.ts
@@ -82,11 +82,6 @@ export const useToolStore = defineStore("toolStore", () => {
     const loading = ref(false);
 
     const searchWorker = ref<Worker | undefined>(undefined);
-    // TODO: Where do we terminate the worker?
-    // onScopeDispose(() => {
-    //     searchWorker.value?.terminate();
-    //     searchWorker.value = undefined;
-    // });
 
     const getToolForId = computed(() => {
         return (toolId: string) => toolsById.value[toolId];