diff --git a/client/src/components/Form/Elements/FormNumber.vue b/client/src/components/Form/Elements/FormNumber.vue index a616bd3d8706..a2d1edb9af5c 100644 --- a/client/src/components/Form/Elements/FormNumber.vue +++ b/client/src/components/Form/Elements/FormNumber.vue @@ -38,11 +38,13 @@ export default { type: [Number, String], required: false, default: undefined, + validator: (prop) => typeof prop == "number" || prop === null, }, max: { type: [Number, String], required: false, default: undefined, + validator: (prop) => typeof prop == "number" || prop === null, }, workflowBuildingMode: { type: Boolean, @@ -74,7 +76,7 @@ export default { return this.workflowBuildingMode ? "text" : "number"; }, isRangeValid() { - return !isNaN(this.min) && !isNaN(this.max) && this.max > this.min; + return typeof this.min == "number" && typeof this.max == "number" && this.max > this.min; }, isInteger() { return this.type.toLowerCase() === "integer"; @@ -124,10 +126,15 @@ export default { } }, isOutOfRange(value) { - return this.isRangeValid && (value > this.max || value < this.min); + /* If value=null, then value is within range. */ + return ( + (typeof this.max == "number" && value > this.max) || (typeof this.min == "number" && value < this.min) + ); }, showOutOfRangeWarning(value) { - const warningMessage = `${value} is out of ${this.min} - ${this.max} range!`; + const rangeDetail = + typeof this.max == "number" && value > this.max ? `${value} > ${this.max}` : `${value} < ${this.min}`; + const warningMessage = `${value} is out of range! (${rangeDetail})`; this.showAlert(warningMessage); }, resetAlert() { diff --git a/client/src/onload/globalInits/initSentry.js b/client/src/onload/globalInits/initSentry.js index c5a32648bd04..9815743e8a3c 100644 --- a/client/src/onload/globalInits/initSentry.js +++ b/client/src/onload/globalInits/initSentry.js @@ -19,9 +19,7 @@ export const initSentry = (galaxy, config) => { Sentry.init({ Vue, dsn: sentry_dsn_public, - integrations: [Sentry.browserTracingIntegration({ router }), Sentry.replayIntegration()], - replaysSessionSampleRate: 0, - replaysOnErrorSampleRate: 1.0, + integrations: [Sentry.browserTracingIntegration({ router })], release: release, beforeSend(event, hint) { const error = hint.originalException; diff --git a/lib/galaxy/config/sample/datatypes_conf.xml.sample b/lib/galaxy/config/sample/datatypes_conf.xml.sample index 315525bc6183..0e026b5a7b0a 100644 --- a/lib/galaxy/config/sample/datatypes_conf.xml.sample +++ b/lib/galaxy/config/sample/datatypes_conf.xml.sample @@ -114,7 +114,11 @@ - + + + SOLID Color-Space sequence data is a rare data type. Consider selecting fasta instead. + + @@ -148,6 +152,9 @@ + + Sequencing data produced since February 2011 is generally using Sanger encoding. Please consider selecting fastqsanger${auto_compressed_type} instead. + @@ -157,6 +164,9 @@ + + Sequencing data produced since February 2011 is generally using Sanger encoding. Please consider selecting fastqsanger${auto_compressed_type} instead. +