From ee3c51037ab485eb0bf2c787b01828e717f26d5c Mon Sep 17 00:00:00 2001 From: John Chilton Date: Thu, 24 Aug 2023 11:15:56 -0400 Subject: [PATCH 01/20] Revise language around non-private object stores. unrestricted caused some totally understandable panic for a user. --- .../components/ObjectStore/ObjectStoreRestrictionSpan.vue | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/client/src/components/ObjectStore/ObjectStoreRestrictionSpan.vue b/client/src/components/ObjectStore/ObjectStoreRestrictionSpan.vue index aed05893e829..4e4a0cbc7515 100644 --- a/client/src/components/ObjectStore/ObjectStoreRestrictionSpan.vue +++ b/client/src/components/ObjectStore/ObjectStoreRestrictionSpan.vue @@ -8,12 +8,12 @@ const props = defineProps({ isPrivate: Boolean, }); -const text = computed(() => (props.isPrivate ? "private" : "unrestricted")); +const text = computed(() => (props.isPrivate ? "private" : "sharable")); const title = computed(() => { if (props.isPrivate) { - return "This dataset is stored on storage restricted to a single user. It can not be shared, published, or added to Galaxy data libraries."; + return "This dataset is stored on storage restricted to a single user. It cannot be shared, published, or added to Galaxy data libraries."; } else { - return "This dataset is stored on unrestricted storage. With sufficient Galaxy permissions, this dataset can be published, shared, or added to Galaxy data libraries."; + return "This dataset is stored on storage that allows standard Galaxy sharing features. If you have sufficient Galaxy permissions to this dataset - the dataset can be published, shared, or added to data libraries within Galaxy."; } }); From 5ff83d81563ba841de705daf91503225eab9cb6b Mon Sep 17 00:00:00 2001 From: John Chilton Date: Mon, 28 Aug 2023 12:11:38 -0400 Subject: [PATCH 02/20] Update unit tests. --- .../components/ObjectStore/ObjectStoreRestrictionSpan.test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/src/components/ObjectStore/ObjectStoreRestrictionSpan.test.js b/client/src/components/ObjectStore/ObjectStoreRestrictionSpan.test.js index 0b5f9f41e902..111c9f98801c 100644 --- a/client/src/components/ObjectStore/ObjectStoreRestrictionSpan.test.js +++ b/client/src/components/ObjectStore/ObjectStoreRestrictionSpan.test.js @@ -13,7 +13,7 @@ describe("ObjectStoreRestrictionSpan", () => { propsData: { isPrivate: true }, localVue, }); - expect(wrapper.find(".stored-how").text()).toBe("private"); + expect(wrapper.find(".stored-how").text()).toMatch("restricted to a single user"); expect(wrapper.find(".stored-how").attributes("title")).toBeTruthy(); }); @@ -22,7 +22,7 @@ describe("ObjectStoreRestrictionSpan", () => { propsData: { isPrivate: false }, localVue, }); - expect(wrapper.find(".stored-how").text()).toBe("unrestricted"); + expect(wrapper.find(".stored-how").text()).toMatch("allows standard Galaxy sharing features"); expect(wrapper.find(".stored-how").attributes("title")).toBeTruthy(); }); }); From 089a5954a47fc8e7810be2ad73ef743d40bca6a4 Mon Sep 17 00:00:00 2001 From: Martin Cech Date: Fri, 15 Mar 2024 10:25:27 -0700 Subject: [PATCH 03/20] fix unit test --- .../components/ObjectStore/ObjectStoreRestrictionSpan.test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/src/components/ObjectStore/ObjectStoreRestrictionSpan.test.js b/client/src/components/ObjectStore/ObjectStoreRestrictionSpan.test.js index 111c9f98801c..d32b70ec4469 100644 --- a/client/src/components/ObjectStore/ObjectStoreRestrictionSpan.test.js +++ b/client/src/components/ObjectStore/ObjectStoreRestrictionSpan.test.js @@ -13,7 +13,7 @@ describe("ObjectStoreRestrictionSpan", () => { propsData: { isPrivate: true }, localVue, }); - expect(wrapper.find(".stored-how").text()).toMatch("restricted to a single user"); + expect(wrapper.find(".stored-how").text()).toMatch("private"); expect(wrapper.find(".stored-how").attributes("title")).toBeTruthy(); }); @@ -22,7 +22,7 @@ describe("ObjectStoreRestrictionSpan", () => { propsData: { isPrivate: false }, localVue, }); - expect(wrapper.find(".stored-how").text()).toMatch("allows standard Galaxy sharing features"); + expect(wrapper.find(".stored-how").text()).toMatch("sharable"); expect(wrapper.find(".stored-how").attributes("title")).toBeTruthy(); }); }); From f8fa8d273820c3e1031dcae33364eaa64f75de22 Mon Sep 17 00:00:00 2001 From: Martin Cech Date: Mon, 9 Oct 2023 17:43:29 -0400 Subject: [PATCH 04/20] attempt to clarify the preferred object store language fix a couple of typos clarify language around switching storage --- .../components/ObjectStore/ConfigurationMarkdown.test.ts | 2 +- client/src/components/ObjectStore/ObjectStoreBadge.vue | 2 +- client/src/components/ObjectStore/SelectObjectStore.vue | 8 +++----- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/client/src/components/ObjectStore/ConfigurationMarkdown.test.ts b/client/src/components/ObjectStore/ConfigurationMarkdown.test.ts index b92180582335..926f96c871b9 100644 --- a/client/src/components/ObjectStore/ConfigurationMarkdown.test.ts +++ b/client/src/components/ObjectStore/ConfigurationMarkdown.test.ts @@ -16,7 +16,7 @@ describe("ConfigurationMarkdown.vue", () => { expect(wrapper.html()).toContain("content"); }); - it("should allow HTML in configuration markdup explicitly set by the admin", () => { + it("should allow HTML in configuration markup explicitly set by the admin", () => { wrapper = shallowMount(ConfigurationMarkdown, { propsData: { markdown: "the content", admin: true }, localVue, diff --git a/client/src/components/ObjectStore/ObjectStoreBadge.vue b/client/src/components/ObjectStore/ObjectStoreBadge.vue index 29f4db692934..d61d9e5f6b2f 100644 --- a/client/src/components/ObjectStore/ObjectStoreBadge.vue +++ b/client/src/components/ObjectStore/ObjectStoreBadge.vue @@ -18,7 +18,7 @@ const MESSAGES = { no_quota: "No Galaxy quota is enabled for this object store.", faster: "This storage has been marked as a faster option by the Galaxy administrator.", slower: "This storage has been marked as a slower option by the Galaxy administrator.", - short_term: "This storage has been marked routinely purged by the Galaxy administrator.", + short_term: "This storage has been marked as routinely purged by the Galaxy administrator.", backed_up: "This storage has been marked as backed up by the Galaxy administrator.", not_backed_up: "This storage has been marked as not backed up by the Galaxy administrator.", more_secure: diff --git a/client/src/components/ObjectStore/SelectObjectStore.vue b/client/src/components/ObjectStore/SelectObjectStore.vue index 36638836208c..0a5d3206f79f 100644 --- a/client/src/components/ObjectStore/SelectObjectStore.vue +++ b/client/src/components/ObjectStore/SelectObjectStore.vue @@ -27,12 +27,10 @@ const { isLoading, loadErrorMessage, selectableObjectStores } = storeToRefs(stor const loadingObjectStoreInfoMessage = ref("Loading object store information"); const whyIsSelectionPreferredText = ref(` -Selecting this will reset Galaxy to default behaviors configured by your Galaxy administrator. -Select a preferred object store for new datasets. This is should be thought of as a preferred -object store because depending the job and workflow configuration execution configuration of -this Galaxy instance - a different object store may be selected. After a dataset is created, +Select a preferred object store for new datasets. Depending on the job and workflow execution configuration of +this Galaxy a different object store may be ultimately used. After a dataset is created, click on the info icon in the history panel to view information about where it is stored. If it -is not stored in the correct place, contact your Galaxy administrator for more information. +is not stored in the place you want, contact Galaxy administrator for more information. `); function variant(objectStoreId: string) { From 9519ffe8f4d44b4d65763ebb55b7195318bae688 Mon Sep 17 00:00:00 2001 From: Martin Cech Date: Fri, 15 Mar 2024 17:25:25 -0700 Subject: [PATCH 05/20] change user-facing language from "object store" to "storage location" --- .../History/CurrentHistory/HistoryCounter.vue | 2 +- .../History/CurrentHistory/PreferredStorePopover.vue | 10 +++++----- .../src/components/ObjectStore/DescribeObjectStore.vue | 8 ++++---- client/src/components/ObjectStore/ObjectStoreBadge.vue | 4 ++-- .../src/components/ObjectStore/SelectObjectStore.vue | 6 +++--- .../ObjectStore/ShowSelectedObjectStore.test.js | 2 +- .../components/ObjectStore/ShowSelectedObjectStore.vue | 2 +- .../components/ObjectStore/showTargetPopoverMixin.js | 2 +- client/src/components/Tool/ToolCard.vue | 2 +- .../components/Tool/ToolSelectPreferredObjectStore.vue | 2 +- .../Tool/ToolTargetPreferredObjectStorePopover.vue | 6 +++--- .../DiskUsage/Quota/ProvidedQuotaSourceUsageBar.vue | 2 +- .../components/User/UserPreferredObjectStore.test.js | 2 +- .../src/components/User/UserPreferredObjectStore.vue | 6 +++--- .../components/Workflow/Run/WorkflowRunFormSimple.vue | 2 +- .../Run/WorkflowSelectPreferredObjectStore.vue | 4 ++-- .../Workflow/Run/WorkflowStorageConfiguration.vue | 4 ++-- .../Run/WorkflowTargetPreferredObjectStorePopover.vue | 6 ++---- 18 files changed, 35 insertions(+), 37 deletions(-) diff --git a/client/src/components/History/CurrentHistory/HistoryCounter.vue b/client/src/components/History/CurrentHistory/HistoryCounter.vue index c70ec3a91e6b..df3f0a1d0e0f 100644 --- a/client/src/components/History/CurrentHistory/HistoryCounter.vue +++ b/client/src/components/History/CurrentHistory/HistoryCounter.vue @@ -206,7 +206,7 @@ onMounted(() => { { diff --git a/client/src/components/ObjectStore/ObjectStoreBadge.vue b/client/src/components/ObjectStore/ObjectStoreBadge.vue index d61d9e5f6b2f..855147b33dbc 100644 --- a/client/src/components/ObjectStore/ObjectStoreBadge.vue +++ b/client/src/components/ObjectStore/ObjectStoreBadge.vue @@ -14,8 +14,8 @@ const MESSAGES = { restricted: "This dataset is stored on storage restricted to a single user. It can not be shared, published, or added to Galaxy data libraries.", user_defined: "This storage was user defined and is not managed by the Galaxy administrator.", - quota: "A Galaxy quota is enabled for this object store.", - no_quota: "No Galaxy quota is enabled for this object store.", + quota: "A Galaxy quota is enabled for this storage location.", + no_quota: "No Galaxy quota is enabled for this storage location.", faster: "This storage has been marked as a faster option by the Galaxy administrator.", slower: "This storage has been marked as a slower option by the Galaxy administrator.", short_term: "This storage has been marked as routinely purged by the Galaxy administrator.", diff --git a/client/src/components/ObjectStore/SelectObjectStore.vue b/client/src/components/ObjectStore/SelectObjectStore.vue index 0a5d3206f79f..82fe46b53c1f 100644 --- a/client/src/components/ObjectStore/SelectObjectStore.vue +++ b/client/src/components/ObjectStore/SelectObjectStore.vue @@ -25,10 +25,10 @@ const props = withDefaults(defineProps(), { const store = useObjectStoreStore(); const { isLoading, loadErrorMessage, selectableObjectStores } = storeToRefs(store); -const loadingObjectStoreInfoMessage = ref("Loading object store information"); +const loadingObjectStoreInfoMessage = ref("Loading storage location information"); const whyIsSelectionPreferredText = ref(` -Select a preferred object store for new datasets. Depending on the job and workflow execution configuration of -this Galaxy a different object store may be ultimately used. After a dataset is created, +Select a preferred storage location for new datasets. Depending on the job and workflow execution configuration of +this Galaxy a different storage location may be ultimately used. After a dataset is created, click on the info icon in the history panel to view information about where it is stored. If it is not stored in the place you want, contact Galaxy administrator for more information. `); diff --git a/client/src/components/ObjectStore/ShowSelectedObjectStore.test.js b/client/src/components/ObjectStore/ShowSelectedObjectStore.test.js index c20e3b861656..275fabe92ddc 100644 --- a/client/src/components/ObjectStore/ShowSelectedObjectStore.test.js +++ b/client/src/components/ObjectStore/ShowSelectedObjectStore.test.js @@ -30,7 +30,7 @@ describe("ShowSelectedObjectStore", () => { }); let loadingEl = wrapper.findComponent(LoadingSpan); expect(loadingEl.exists()).toBeTruthy(); - expect(loadingEl.find(".loading-message").text()).toContainLocalizationOf("Loading object store details"); + expect(loadingEl.find(".loading-message").text()).toContainLocalizationOf("Loading storage location details"); await flushPromises(); loadingEl = wrapper.findComponent(LoadingSpan); expect(loadingEl.exists()).toBeFalsy(); diff --git a/client/src/components/ObjectStore/ShowSelectedObjectStore.vue b/client/src/components/ObjectStore/ShowSelectedObjectStore.vue index bbebc6442e1e..3b1c4cdfd087 100644 --- a/client/src/components/ObjectStore/ShowSelectedObjectStore.vue +++ b/client/src/components/ObjectStore/ShowSelectedObjectStore.vue @@ -38,7 +38,7 @@ watch( } ); fetch(); -const loadingMessage = "Loading object store details"; +const loadingMessage = "Loading storage location details";