Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spock-core test failure with http-types 0.11 #138

Open
DanBurton opened this issue Jan 25, 2018 · 1 comment
Open

Spock-core test failure with http-types 0.11 #138

DanBurton opened this issue Jan 25, 2018 · 1 comment

Comments

@DanBurton
Copy link

As seen on the Stackage build server:

Failures:

  test/Web/Spock/Internal/CookiesSpec.hs:95:
  1) Generating Cookies, cookie value, should be urlencoded
       Failed to find "foo=most%2Bspecial%20chars%3B%25%D0%B1%D0%B8%D1%81%D0%BA%D0%B2%D0%B8%D1%82%D0%BA%D0%B8" in "foo=most%2bspecial%20chars%3b%25%d0%b1%d0%b8%d1%81%d0%ba%d0%b2%d0%b8%d1%82%d0%ba%d0%b8; Path=/"

Randomized with seed 312630884

Finished in 0.0068 seconds
56 examples, 1 failure

This is presumably due to the change as noted in the http-types changelog:

Remove dependency on blaze-builder. (Note that as a side effect of this, URI encoding is now using lower-case rather than uppercase hexadecimal.)

What is your take on the severity of this test failure? Do you think Stackage should hold back or move forward with http-types 0.11?

See also: commercialhaskell/stackage#3226

@aristidb
Copy link

http-types 0.12 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants