Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AG0018 Don't block IReadOnlyCollection<T> #156

Closed
szaboopeeter opened this issue Mar 2, 2021 · 4 comments · Fixed by #157
Closed

AG0018 Don't block IReadOnlyCollection<T> #156

szaboopeeter opened this issue Mar 2, 2021 · 4 comments · Fixed by #157

Comments

@szaboopeeter
Copy link
Member

@szaboopeeter Our team, would like to use IReadOnlyCollection<> which results in quite a bit of warnings. I can update the docs if we agree to allow this.

Originally posted by @inemtsev in #155 (comment)

@szaboopeeter
Copy link
Member Author

@inemtsev Sounds good to me. Personally I don't see any problem in allowing any or all of the System.Collections.Generic interfaces https://docs.microsoft.com/en-us/dotnet/api/system.collections.generic?view=net-5.0#interfaces

@inemtsev
Copy link

inemtsev commented Mar 2, 2021

Totally agree.

@inemtsev
Copy link

inemtsev commented Mar 2, 2021

@szaboopeeter I cloned the project and made the change, but Github doesnt let me push. Do I need some special permissions?

@szaboopeeter
Copy link
Member Author

Easiest way is if you fork it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants