-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Loading Existing Multisafe UX #125
Comments
If the user has visited multisafe before, when disconnecting account we should just persist that in local storage so that when the user re-authenticates the safe can be added back in. It is strange though to get visibility on a safe that you have no permissions over. |
@agileurbanite That's a great idea. There is one issue. At this moment Multisafe is supporting only one account at a time, so it's storing (in local storage) state for one account only. There might be a situation:
Of course, we can leave it this way, but I think it would be better to handle it and make it work properly. We can solve it by:
An additional advantage would be that by introducing this functionality we will be able to introduce functionality to support multiple accounts much easier if we would decide to do that - it will be basically ready. Additional thing is that if we would like to keep the state in local storage, I think we should do two additional things:
|
@agileurbanite So if we would like to support showing a safe data to user that isn't a member, we can handle it much better. IMO we should separate it from loading safe flow, and the existing safes list. So the user will not be With this, it would be also possible to share the link to the safe, without the need to load the safe. For example, if someone would like to share the safe data with someone who is not a member. Also, we need to handle situations, when a user was a member of the safe, so he has this safe on the safes list, but he was removed from the safe members. |
Loading existing multisafe is not obvious UX that you need to enter the full account name of a multisafe to use said multisafe....
Almost a BUG imo.
The text was updated successfully, but these errors were encountered: