Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Styling Inheritance and Conflicts - Part 2 #96

Open
Anhtrr opened this issue Mar 10, 2023 · 1 comment · Fixed by #97
Open

Fix Styling Inheritance and Conflicts - Part 2 #96

Anhtrr opened this issue Mar 10, 2023 · 1 comment · Fixed by #97
Assignees
Labels
Spike Task not directly related to feature/product

Comments

@Anhtrr
Copy link
Contributor

Anhtrr commented Mar 10, 2023

No description provided.

@Anhtrr Anhtrr self-assigned this Mar 10, 2023
@Anhtrr Anhtrr added the Spike Task not directly related to feature/product label Mar 10, 2023
@Anhtrr
Copy link
Contributor Author

Anhtrr commented Mar 10, 2023

@cph323 @chloeph323

Please remember to not style components directly in .css files when you are working on individual pages. For example, don't style a "div" just because you use div in your page. Your styles will apply to all other pages that contains "div"s even if your .css file is not imported in other pages. It just gives our group more work to go back and edit it. Instead, please name your component's className="something_specific_to_your_page" and style it based on that class name so it doesn't affect other member's work and the entire app as a whole.

StevenZhang0116 pushed a commit that referenced this issue Mar 10, 2023
…ix-styles-conflicts

fixed category style conflicts with global pages
@Anhtrr Anhtrr linked a pull request Mar 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spike Task not directly related to feature/product
Projects
None yet
1 participant