Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MPSK #498

Open
mabezi opened this issue Aug 10, 2024 · 5 comments
Open

Add support for MPSK #498

mabezi opened this issue Aug 10, 2024 · 5 comments

Comments

@mabezi
Copy link
Contributor

mabezi commented Aug 10, 2024

In order for MPSK to be used by our members, a suitable frontend with connection to the Pycroft API (not yet available) must be implemented.

The user should be able to see a list of MAC addresses along with self-assigned device names. For better usability, it should not only be possible for the user to add or delete addresses but also to edit them when needed (e.g. to fix typos)

The following potential errors must be displayed in the frontend with appropriate messages:

  • Invalid MAC address
  • Already assigned MAC address
  • Legacy passwords (see the related note in the Pycroft issue)

The implementation can partially follow the existing process for changing MAC addresses.

It would be very useful to have a clearly visible notice indicating that the MAC address is not for the physical port but for WiFi (and vice versa).

It might also be worth considering placing the display of the WiFi password near the list, creating a major section called "WiFi." However, this is optional.

@mabezi
Copy link
Contributor Author

mabezi commented Aug 10, 2024

Pycroft Issue: agdsn/pycroft#744

@lukasjuhrich
Copy link
Collaborator

Will these devices also work via the agdsn ssid? I am thinking about how we communicate the difference between enterprise wifi and mpsk-wifi most effectively to the members.

I think some "branding" would really help here, also with respect to clarifying the distinction between "the agdsn wifi" vs. "your router's wifi". I'm thinking along these lines, where we would replace the W with a wifi icon:

image

I'm not really fixated on the color, this is a rough sketch.
for the source see this tailwind prototype.

@ibot3
Copy link
Member

ibot3 commented Aug 12, 2024

Will these devices also work via the agdsn ssid? I am thinking about how we communicate the difference between enterprise wifi and mpsk-wifi most effectively to the members.

There will be a separate SSID like agdsn-mpsk or similar.
The agdsn SSID is for enterprise wifi with username/password only.

@mabezi
Copy link
Contributor Author

mabezi commented Aug 14, 2024

Currently agdsn-mpsk is planned and configured as SSID.

@lukasjuhrich
Copy link
Collaborator

lukasjuhrich commented Aug 14, 2024

Okay, so: updated suggestion: https://play.tailwindcss.com/Or1PTD16dY
image

agmes4 added a commit that referenced this issue Oct 3, 2024
added the first implentation for the client it self
still a lot to do
#498
agmes4 added a commit that referenced this issue Oct 27, 2024
added mpsk client to user profile
#498
agmes4 added a commit that referenced this issue Oct 27, 2024
added mpsks form implementation for etiting and adding clients
#498
agmes4 added a commit that referenced this issue Oct 27, 2024
updated html for mpsks
#498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

3 participants