Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app is ready for review. #1

Open
aftabnaqvi opened this issue Oct 2, 2014 · 1 comment
Open

app is ready for review. #1

aftabnaqvi opened this issue Oct 2, 2014 · 1 comment

Comments

@aftabnaqvi
Copy link
Owner

My app is complete, please review it. I implemented all required and mostly optional(advance and bonus) features except persistence and detail activity. detail activity is 90% done, I was having the issue while passing the data to detail activity using Parcelable interface.

Thanks,
Syed

@nesquena
@thecodepath

@codepathreview
Copy link

👍 Great work Syed. A few notes after checking out the code:

  • Your attention to UI/UX was impressive.
  • Good to see you were able to format the timestamp cleanly
  • Good to see you refreshed the timeline after composing a new tweet
  • Nice touch with the character count being displayed while the user composes a tweet by using TextWatcher
  • Nice to see you used a PullToRefresh library for easy timeline refreshes
  • Glad to see you made the compose activity into a dialog instead
  • Good job using progress bar when network request goes out
  • Consider adding ActiveAndroid to the Tweet and User. See the persistence guide and this other guide for more details.

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants