Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset property type needs to parse attrValue when updating #4579

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Asset property type needs to parse attrValue when updating #4579

wants to merge 1 commit into from

Commits on May 7, 2020

  1. Asset property type needs to parse attrValue when updating 

    Only in components with single-property schema asset is not parsed when updating (for example gltf-model)
So #asset-id will not be converted in url necessary for this.data.
Maybe instead of doing this in propertyTypes we should add the possibility to force a parse, like:
function registerPropertyType (type, defaultValue, parse, stringify, parseRequired)
so it becomes
registerPropertyType('model', '', assetParse, undefined, true);
and then in the code commited above instead of checking the parse function name, we check if (this.schema.parseRequired)
    Marco Paoliello committed May 7, 2020
    Configuration menu
    Copy the full SHA
    4bf7441 View commit details
    Browse the repository at this point in the history