-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slider out of sync when layout changes #141
Comments
I'd be happy to look into this myself if you could give me some pointers on how to build the current version on the Master branch and which typescript files are relevant. |
Hi @developandplay, thank you for reporting this. I feel like this has come up before. I would look into the upstream issues and see when it was fixed and why it is not fixed in our code base. I feel like it should have been fixed in material-components-web-6.0.0 already, which this library is currently using. Note that I am building from a fork inside the submodule material-components-web, so I might have maybe introduced in error in one of my patches. I might get around investigating this myself, but if you want to take a stab at it, I'd appreciate it! Recent master should build again! You have to clone this repository and submodules and run I am also very excited to see material-components-web-miso. Please do feel free to reach out to me if you want to discuss anything! |
Hm the way you setup the submodule gives me a permission denied error when using |
This seems to be #69 reoccurring. |
I think this is still an unresolved upstream bug material-components/material-components-web#1017 (later comments talk about the interaction with drawer instead of dialog). |
I could expose |
I think that sounds like a good idea in the meantime. |
Describe the bug
The slider values get out of sync when the layout changes or sometimes even on load. After resizing the window everything works as expected
To Reproduce
Either go to the demo website material-components-web-elm or the demo website of material-components-web-miso. On the elm website then open the sandwich menu and then move the slider. On the miso website the slider is opened already and the slider out of sync on page load.
Expected behavior
The slider should be in sync on page load and after layout changes.
Screenshots
Elm:
Miso:
Desktop (please complete the following information):
Additional context
I'm porting the material-components-web-elm to material-components-web-miso. Fortunately I can reuse all of the javascript.
Unfortunately I wasn't able to build the javascript on the Master branch so the issue might be already fixed on Master but it occurs on 6.0.0.
The text was updated successfully, but these errors were encountered: