Skip to content
This repository has been archived by the owner on Oct 13, 2022. It is now read-only.

StatusColor に null を追加する #131

Open
Takeno-hito opened this issue Sep 4, 2021 · 2 comments
Open

StatusColor に null を追加する #131

Takeno-hito opened this issue Sep 4, 2021 · 2 comments
Labels
refactor Without changing its external behavior

Comments

@Takeno-hito
Copy link
Member

QRScannerコンポーネント内で

<QRScanner
    onScanFunc={handleScan}
    videoStop={false}
    color={checkStatus ?? undefined}
/>

というundefinedを指定する謎の実装がされていて、根本までたどると statuscolor に待機中の状態を示すものがない事が原因っぽいので、searching的な新たなstatuscolorを作る

@Takeno-hito Takeno-hito added the refactor Without changing its external behavior label Sep 4, 2021
@su8ru
Copy link
Member

su8ru commented Sep 7, 2021

null じゃだめなの?

@su8ru
Copy link
Member

su8ru commented Sep 7, 2021

color 未指定と searching を指定したときの挙動が同じなの気持ち悪いので null でいいと思います
もしくは default

@Takeno-hito Takeno-hito changed the title StatusColor に searching 的なのを追加する StatusColor に null を追加する Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Without changing its external behavior
Projects
None yet
Development

No branches or pull requests

2 participants