Setting data inside an array fires an add event on the parent array #60

uplift · 2012-09-23T10:59:58Z

I put together this jsfiddle to show what I mean.

I'd expect to only see one 'added' displayed but seeing three. I've narrowed it down to this line

https://github.com/afeld/backbone-nested/blob/master/backbone-nested.js#L262

but cant see an obvious fix. Any ideas?

afeld · 2012-09-23T21:43:03Z

Hmm, yep, add() is using set() under the hood, but should probably be checking isNewValue (or something) before firing that event. Looking into it now.

demonstrates issue where setting a value inside a nested array erroneously triggers and add event, when no item has been added

Checks whether or not the set method call will add a new item to a nested array. If not, the ‘add’ event is not triggered where previously it would.

tomhicks added a commit to tomhicks/backbone-nested that referenced this issue May 11, 2014

test case for PR afeld#60

3d9b9cb

demonstrates issue where setting a value inside a nested array erroneously triggers and add event, when no item has been added

tomhicks mentioned this issue May 11, 2014

test case for issue #60 #117

Open

tomhicks added a commit to tomhicks/backbone-nested that referenced this issue May 11, 2014

fix for issue afeld#60 and afeld#117

07683a7

Checks whether or not the set method call will add a new item to a nested array. If not, the ‘add’ event is not triggered where previously it would.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setting data inside an array fires an add event on the parent array #60

Setting data inside an array fires an add event on the parent array #60

uplift commented Sep 23, 2012

afeld commented Sep 23, 2012

Setting data inside an array fires an add event on the parent array #60

Setting data inside an array fires an add event on the parent array #60

Comments

uplift commented Sep 23, 2012

afeld commented Sep 23, 2012