Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicates #18

Open
benjaminpope opened this issue Jun 2, 2021 · 1 comment
Open

Duplicates #18

benjaminpope opened this issue Jun 2, 2021 · 1 comment

Comments

@benjaminpope
Copy link

Hi Adina,

Reprocessing all our data for the paper using the latest version of stella (more on that when finished!)

Noticed a funny bug: take (say) the 120s data for 2MASS J09481615+5114518 in Sector 21. We get the avg_preds from the ensemble prediction over the new models (seems fine) and obtain a flare table with

ff = stella.FitFlares(id=tics, time=time, flux=flux, predictions=avg_preds, flux_err=errs) ff.identify_flare_peaks(threshold=0.6)

we get many duplicates in the flare table.

These are exact duplicates so you can just filter them with unique(flare_table) but concerned there is a deeper bug?

Cheers,

Ben

@benjaminpope
Copy link
Author

Also finding quite a few flares missed in CR Dra in fit_flares vs spikes with high CNN probability that look good by eye...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant