Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Request internals #13

Open
mightybyte opened this issue Dec 13, 2015 · 2 comments
Open

Expose Request internals #13

mightybyte opened this issue Dec 13, 2015 · 2 comments
Assignees

Comments

@mightybyte
Copy link

A fairly common abstraction I've encountered is something that needs both a Request and the request's path or host. The way things currently stand now with the opaque Request type there is no way to nicely implement these kinds of abstractions. You have to pass both the Request and the path, but that is more error prone since the Request contains the path. Exposing more (all?) of the Request internals would admit the nice solution in these cases.

@istathar
Copy link
Member

It's high time this got some love. I'll look into it this week. The trouble I have with all of this class of request is that the whole point of hiding internals is so that special (required) things can be done correctly. If there are use cases we're not supporting well (and there are) then we really need to rethink the API as a whole.

AfC

@istathar istathar self-assigned this Jan 17, 2016
@mightybyte
Copy link
Author

Thanks. I'm not too concerned with the details of the implementation--just that I can "say all the things".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants