Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update list components #34

Open
1 of 6 tasks
cshawaus opened this issue Aug 8, 2020 · 0 comments
Open
1 of 6 tasks

Update list components #34

cshawaus opened this issue Aug 8, 2020 · 0 comments
Assignees
@cshawaus
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
Road to v3 🚀

Comments

@cshawaus
Copy link
Member

cshawaus commented Aug 8, 2020 •
edited
Loading

The current list components work but don't provide enough extensibility from a framework perspective. It would be good if the following could be achieved.

  • Add toggle for tags as to whether the details component will be searched in addition to cq:tags in page properties
  • Migrate feeds to servlets
  • Ensure all dialogs are following consistent conventions and have associated design dialogs
  • Custom policies disable any authored inputs for parody
  • Models are easily overridable and extensible
  • Create a method by which custom badge structures can be used for any list

Further improvements to come!
@cshawaus cshawaus added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 8, 2020
@cshawaus cshawaus added this to the Road to v3 🚀 milestone Aug 8, 2020
@cshawaus cshawaus self-assigned this Aug 8, 2020
cshawaus added a commit that referenced this issue Aug 10, 2020
@cshawaus
#34 - Fixed a number of bugs with lists
7cbaf83 
- Fixed the default order by value
- Fixed how the component name and details component lookup names are set
- Other small tweaks and optimisations
cshawaus added a commit that referenced this issue Aug 10, 2020
@cshawaus
#34 - Restored pagniation to lists
5c3a212 
This change only restores the ability to define the starting offset for pages. The previous implementation allowed custom queries/query builder strings to be used which didn’t make much sense as it introduces an easy way to abuse pagniation and possibily introduces path vector attacks.
cshawaus added a commit that referenced this issue Aug 10, 2020
@cshawaus
#34 - Started working on feed servlets
8272f95 
The existing JSP feeds are clunky and extremely difficult to maintain, this commit kicks off the next version of feeds that will be extensible, easily updatable and will implement best practices.
cshawaus added a commit that referenced this issue Aug 10, 2020
@cshawaus
#34 - Minor code convention tweaks
e35c0e9
cshawaus added a commit that referenced this issue Aug 11, 2020
@cshawaus
#34 - Implemented a new method for fields/defaults
5f59ef9 
This commit experiements with the idea of using static methods to define the component fields and defaults to go with them. Conceptually, this will allow for far easier overrides of pre-defined fields by allowing just the default to be overriden via `getComponentFieldsDefaults`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cshawaus cshawaus

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Road to v3 🚀
Development

No branches or pull requests
1 participant
@cshawaus