Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Maven Compilation #25

Open
hendursaga opened this issue Sep 19, 2022 · 3 comments
Open

Fix Maven Compilation #25

hendursaga opened this issue Sep 19, 2022 · 3 comments

Comments

@hendursaga
Copy link

I really don't see how sustainable downloading a huge bundle of dependencies from an external repository and then running a handwritten bash/PowerShell script to compile and package everything is going to be. I see there's a pom.xml file, and have been trying to get Maven to compile and package a working JAR, but the META-INF/MANIFEST.MF file I presume it is copying over as opposed to generating does NOT contain a Main-Class attribute, which I had to manually add. The pom.xml appears to be rather out-of-date, as, among other things, it doesn't seem to include steamworks4j among other dependencies..

@aehmttw
Copy link
Owner

aehmttw commented Sep 19, 2022

I'll look into updating the pom.xml soon if I can get a working steamworks4j on maven. For now, the way I recommend building and running the game is via IntelliJ, with main.Tanks as the main class. You can make Tanks.jar be a build artifact with IntelliJ too, including all the dependencies, and it should work.

@ghostlypi
Copy link
Collaborator

The bundled build scripts for tanks are the easiest way to build Tanks for any platform. While this does not solve the issue of an up to date pom.xml, it does enable easy building on any platform with a terminal (tested on x86, macOS, and aarch64).

@ghostlypi
Copy link
Collaborator

This is a very dead horse, but I finally got around to fixing the maven compilation. Still not optimal, but much cleaner than the old system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants