Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on_event: expand certain event parameters #2524

Open
ivan-mogilko opened this issue Sep 1, 2024 · 0 comments
Open

on_event: expand certain event parameters #2524

ivan-mogilko opened this issue Sep 1, 2024 · 0 comments

Comments

@ivan-mogilko
Copy link
Contributor

ivan-mogilko commented Sep 1, 2024

#2468 task required to add x,y coordinate parameters for on_mouse_click.
But there are also eEventGUIMouseDown and eEventGUIMouseUp events handled by on_event that also may require these.
For instance, some of the game templates are handling these, and use mouse.x/mouse.y to know the position, although, since on_event is scheduled, this position may already be different.

Another thing, there's event eEventGameSaved, but there's no way to tell if it was successful or not. Right now the engine simply displays a standard hardcoded message in case a save file failed to open. I think it should not be doing that, and let game developer handle this instead. This may be done by passing an extra parameter along eEventGameSaved, which tells the boolean result of the save operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant