feat: added spot ws service, moved client to common, refactoring #633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here I implemented Binance spot ws service and did some refactoring.
Common mechanics of websocket client I moved to common/websocket package (it's identical for each service, I don't want to have duplicates). Configuration of endpoint, using keep alive and other parameters can be used like in general way of this lib - from global vars of each package. So setting up common client can be done flexible and without breaking main architecture.
For example,
We can create futures.NewOrderPlaceWsService, which uses its own function to establish connection/resolving url/using keepalive and so on. Check code in constructor for more details.
I also tried to reduce some interfaces, change naming for better following SRP.
Thanks