Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRADE_LITE user-data WS event #612

Closed
vlw opened this issue Sep 3, 2024 · 4 comments
Closed

TRADE_LITE user-data WS event #612

vlw opened this issue Sep 3, 2024 · 4 comments

Comments

@vlw
Copy link
Contributor

vlw commented Sep 3, 2024

Binance introduced new event in userdata WS: https://www.binance.com/en/support/announcement/introducing-trade-lite-for-usd%E2%93%A2-m-futures-websocket-2024-09-03-f2809259702b46f7abdc9c97b977908f

https://developers.binance.com/docs/derivatives/usds-margined-futures/user-data-streams/Event-Trade-Lite

it's incompatible with our futures.WsUserDataEvent

type WsUserDataEvent struct {
    Event               UserDataEventType     `json:"e"`
    Time                int64                 `json:"E"`
    CrossWalletBalance  string                `json:"cw"`
    MarginCallPositions []WsPosition          `json:"p"`
    TransactionTime     int64                 `json:"T"`
    AccountUpdate       WsAccountUpdate       `json:"a"`
    OrderTradeUpdate    WsOrderTradeUpdate    `json:"o"`
    AccountConfigUpdate WsAccountConfigUpdate `json:"ac"`
}

json: cannot unmarshal string into Go struct field .p of type []futures.WsPosition

@vlw
Copy link
Contributor Author

vlw commented Sep 3, 2024

Previously all WS responses were compatible with each other, looks like a malformed API on Binance's part

@xyq-c-cpp
Copy link
Collaborator

Previously all WS responses were compatible with each other, looks like a malformed API on Binance's part

does that problem still occur? @vlw

@vlw
Copy link
Contributor Author

vlw commented Sep 4, 2024

does that problem still occur?

yes

@xyq-c-cpp
Copy link
Collaborator

does that problem still occur?

yes

okay, it's great if you can check what exactly happens and open a PR to fix this issue, if you have free time. @vlw

Menfre01 added a commit to Menfre01/go-binance that referenced this issue Sep 10, 2024
Menfre01 added a commit to Menfre01/go-binance that referenced this issue Sep 10, 2024
0x0001 added a commit to 0x0001/go-binance that referenced this issue Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants