Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixed frustum culling debugger (and re-enabled frustum light culling) #327

Draft
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

adriengivry
Copy link
Owner

@adriengivry adriengivry commented Nov 22, 2024

Description

  • Frustum culling can now be used in the editor to speed up the rendering (Scene View, Asset View...)!
  • Frustum culling debugging now works properly (override frustum culling by using the main camera frustum)

Review Guidance

This PR has changes conflicting with #315, so waiting for it to be merged before merging this one.

Please ignore the massive "Files changed" as most of them are related to the mentioned PR.

To-Do

Related Issues

Fixes #322

…un automatically even if no source file changed (to make sure resources are copied properly)
* enforced single shadow map
* added support for PBR shadow receiving
…ny temporary TextureHandle (such as a ShadowMap) passed to a material will be released after use (to avoid accessing deallocated memory)
* Frustum culling can now be used in the editor to speed up the rendering!
* Frustum culling debugging now works properly (override frustum culling by using the main camera frustum)
* Still need to fix the light frustum culling (I think the implementation is missing)
@adriengivry adriengivry added Bug Something isn't working Feature New feature to the engine Editor Something relative with the editor Optimization Optimization related stuff labels Nov 22, 2024
@adriengivry adriengivry self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Editor Something relative with the editor Feature New feature to the engine Optimization Optimization related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frustum culling isn't working properly
1 participant