-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fixed frustum culling debugger (and re-enabled frustum light culling) #327
Draft
adriengivry
wants to merge
24
commits into
develop
Choose a base branch
from
fix/frustum_culling
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…manent solution has been found
…un automatically even if no source file changed (to make sure resources are copied properly)
* enforced single shadow map * added support for PBR shadow receiving
…exposed to the material editor
…ny temporary TextureHandle (such as a ShadowMap) passed to a material will be released after use (to avoid accessing deallocated memory)
* Frustum culling can now be used in the editor to speed up the rendering! * Frustum culling debugging now works properly (override frustum culling by using the main camera frustum) * Still need to fix the light frustum culling (I think the implementation is missing)
adriengivry
added
Bug
Something isn't working
Feature
New feature to the engine
Editor
Something relative with the editor
Optimization
Optimization related stuff
labels
Nov 22, 2024
adriengivry
requested review from
litelawliet,
maxbrundev and
BenjaminViranin
November 22, 2024 00:16
…t culling as well as its debug feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
Something isn't working
Editor
Something relative with the editor
Feature
New feature to the engine
Optimization
Optimization related stuff
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Review Guidance
This PR has changes conflicting with #315, so waiting for it to be merged before merging this one.
Please ignore the massive "Files changed" as most of them are related to the mentioned PR.
To-Do
Related Issues
Fixes #322