Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Add Download Verification check for source tarballs #3801

Open
adamfarley opened this issue May 8, 2024 · 2 comments
Open

Comments

@adamfarley
Copy link
Contributor

adamfarley commented May 8, 2024

Something went wrong with publishing source tarballs for the Jan 2024 update. See: adoptium/adoptium-support#1003 we should make sure that it's there with some verification for any release.

Originally posted by @jerboaa in adoptium/temurin#28 (comment)

@sxa
Copy link
Member

sxa commented May 8, 2024

We'll need to think about this a little more - there won't necessarily be one for a point release for example.

I guess we could check for it ONLY if the release contains Linux/x64 ..

@jerboaa
Copy link
Contributor

jerboaa commented May 8, 2024

Consider using the API and verifying that sources can get downloaded for the specific release. E.g. for 21.0.3:

$ curl -v https://api.adoptium.net/v3/binary/latest/21/ga/linux/x64/sources/hotspot/normal/eclipse 2>&1 | grep Location | grep 21.0.3
< Location: https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.3%2B9/OpenJDK21U-jdk-sources_21.0.3_9.tar.gz

This hard-codes x64, but that's fine for this check. It's only published for that arch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants