Bugfix: Automatically generated linux installer packages are not being signed. #1111
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw.
steelhead31
force-pushed
the
fix_jre_signing
branch
from
82efbf5 to
dbedc16
Compare
|
This now produces signed packages.. rpm -qpi temurin-23-jre-23.0.2.0.0.7-0.x86_64.rpm JDK rpm -qpi temurin-23-jdk-23.0.2.0.0.7-0.x86_64.rpm |
|
/merge |
|
Approval to merge during the lockdown cycle Please can two Adoptium PMC members comment |
|
/approve |
1 similar comment
|
/approve |
github-actions
bot
dismissed
their stale review
Thank you @andrew-m-leonard and @jerboaa for your approvals, this pull request is now approved to merge during release.
Fixes #1110
The passing of the relevant key to the gradle builds to produced sign rpms & apks was not working correctly due to the calling of the gradle build outside of the withCredentials block.
Alpine needs the rsa gpg key
Rhel / Suse need the gpg key
Debian does not use the jenkins provided gpg key.
This code explicitly forces each package type to be built and signed correctly.
Once this is merged, I'll push updated packages for everything that has already been released.