Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude failing tests, won't fix 21.0.5 & 17.0.13 #5674

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

sophia-guo
Copy link
Contributor

Exclude failing tests, won't fix 21.0.5 & 17.0.13

@sophia-guo sophia-guo self-assigned this Oct 8, 2024
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not also want to exclude them in aqa-tests master, or do they pass there?

@sophia-guo
Copy link
Contributor Author

sophia-guo commented Oct 9, 2024

Test failed now in aqa-tests. The reason is even though aqa-test master will grab openjdk tests the dev branch by default ( the fix is in dev and 21.0.6, 17.0.14, https://bugs.openjdk.org/browse/JDK-8338748) , the latest or nightly jdk itself are still tagged with 21.0.5 and 17.0.13. Once release is over tests should pass with new tags 21.0.6 and 17.0.14. We can disable them if it fail later (suppose it will pass)

@smlambert smlambert merged commit 85bb6b3 into adoptium:v1.0.4-release Oct 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants