-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3016] Assume that there are EA versions for versions between 16 and … #3059
[3016] Assume that there are EA versions for versions between 16 and … #3059
Conversation
…most_recent_feature_version
✅ Deploy Preview for eclipsefdn-adoptium ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3059 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 90 90
Lines 4951 4968 +17
Branches 618 624 +6
=======================================
+ Hits 4925 4942 +17
Misses 26 26 ☔ View full report in Codecov by Sentry. |
Does somebody can re-run a full build/deploy to ensure everything is Ok? 🙏 |
@xavierfacq The netlify build seemed to be OK and almost produced the desiredv result (under nightly builds |
You are right so I did the fix, so that all missing version will be name 'XX - EA'. |
…github.com:xavierfacq/adoptium.net into 3016-java-23-ea-missing-on-the-nightly-builds-page
Description of change
This is a PR to answer to the issue #3016
It is a proposition to deal with missing version numbers returned by the API.
"assume that there are EA versions for versions between 16 and most_recent_feature_version"
Check here: https://deploy-preview-3059--eclipsefdn-adoptium.netlify.app/fr/temurin/nightly/?version=23
Checklist
npm test
passes