-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve marketplace vendors behavior #2168
Merged
gdams
merged 10 commits into
adoptium:main
from
xavierfacq:feature/improve_marketplace_vendors_behavior
Aug 29, 2023
Merged
Improve marketplace vendors behavior #2168
gdams
merged 10 commits into
adoptium:main
from
xavierfacq:feature/improve_marketplace_vendors_behavior
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclipsefdn-adoptium ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2168 +/- ##
==========================================
- Coverage 99.17% 99.17% -0.01%
==========================================
Files 85 86 +1
Lines 6306 6294 -12
Branches 531 536 +5
==========================================
- Hits 6254 6242 -12
Misses 52 52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gdams
requested changes
Aug 27, 2023
src/components/VendorSelector/__tests__/VendorSelector.test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: George Adams <[email protected]>
…etVendorIdentifier()
gdams
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR is a proposal to improve the Vendors code in the Marketplace page (following the #2131)
Generally speaking: make the code easier to understand and maintain in the future
Checklist
npm test
passes