Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve marketplace vendors behavior #2168

Merged

Conversation

xavierfacq
Copy link
Member

@xavierfacq xavierfacq commented Aug 26, 2023

Description of change

This PR is a proposal to improve the Vendors code in the Marketplace page (following the #2131)

  • loading of the vendor list & avoid double load of the list at startup
  • normalize variables in DownloadDropdowns/index.tsx
  • improve the vendor JSON to add the 'identifier' of the vendor
  • DownloadDropdowns is now using a list of selected vendor identifiers and NOT a list of ref to HTML objects ( 😱 )
  • getAllPkgsForVersion() method receives now a list of vendor identifiers and NOT a list ref to HTML objects ( 😱 )

Generally speaking: make the code easier to understand and maintain in the future

Checklist

  • npm test passes

@netlify
Copy link

netlify bot commented Aug 26, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 1f0f0a7
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/64eb8a86d39f430008b4123d
😎 Deploy Preview https://deploy-preview-2168--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #2168 (1f0f0a7) into main (3cad9b7) will decrease coverage by 0.01%.
Report is 12 commits behind head on main.
The diff coverage is 97.61%.

@@            Coverage Diff             @@
##             main    #2168      +/-   ##
==========================================
- Coverage   99.17%   99.17%   -0.01%     
==========================================
  Files          85       86       +1     
  Lines        6306     6294      -12     
  Branches      531      536       +5     
==========================================
- Hits         6254     6242      -12     
  Misses         52       52              
Files Changed Coverage Δ
src/components/VendorSelector/index.tsx 98.03% <96.15%> (-1.97%) ⬇️
src/components/DownloadDropdowns/index.tsx 93.91% <100.00%> (+0.43%) ⬆️
src/hooks/fetchMarketplace.tsx 100.00% <100.00%> (ø)
src/util/vendors.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xavierfacq xavierfacq marked this pull request as ready for review August 26, 2023 22:48
src/json/marketplace.json Outdated Show resolved Hide resolved
@xavierfacq xavierfacq requested a review from gdams August 28, 2023 09:20
@gdams gdams merged commit 970d170 into adoptium:main Aug 29, 2023
0 of 2 checks passed
@xavierfacq xavierfacq deleted the feature/improve_marketplace_vendors_behavior branch September 7, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants