MWPW-133726 add smart redirects for (temporary) client-side redirects

[trieloff]

• add smart redirects for (temporary) client-side redirects

this is a port of adobe/helix-website#671 and adobe/helix-website#670
from www.aem.live to bacom, see discussion in https://adobe.enterprise.slack.com/archives/C0749KS9F8X

Resolves: MWPW-133726

Test URLs
Simple Redirect

• Before: https://main--bacom--adobecom.hlx.page/drafts/methomas/page-does-not-exist
• After: https://smart-redirects--bacom--adobecom.hlx.page/drafts/methomas/page-does-not-exist
• Should redirect to: https://smart-redirects--bacom--adobecom.hlx.page/drafts/methomas/smart-redirects-end/page-1?redirect_from=%2Fdrafts%2Fmethomas%2Fpage-does-not-exist

One parameter redirect

• Before: https://main--bacom--adobecom.hlx.page/drafts/methomas/folder-does-not-exist/page-1
• After: https://smart-redirects--bacom--adobecom.hlx.page/drafts/methomas/folder-does-not-exist/page-1
• Should redirect to: https://smart-redirects--bacom--adobecom.hlx.page/drafts/methomas/smart-redirects-end/page-1?redirect_from=%2Fdrafts%2Fmethomas%2Ffolder-does-not-exist%2Fpage-1

Multi-parameter redirect

• Before: https://main--bacom--adobecom.hlx.page/drafts/methomas/folder-does-not-exist-2/a/b
• After: https://smart-redirects--bacom--adobecom.hlx.page/drafts/methomas/folder-does-not-exist-2/a/b
• Should redirect to: https://smart-redirects--bacom--adobecom.hlx.page/drafts/methomas/smart-redirects-end/a/products/b?redirect_from=%2Fdrafts%2Fmethomas%2Ffolder-does-not-exist-2%2Fa%2Fb

Different order parameter redirect

• Before: https://main--bacom--adobecom.hlx.page/drafts/methomas/folder-does-not-exist-3/a/b
• After: https://smart-redirects--bacom--adobecom.hlx.page/drafts/methomas/folder-does-not-exist-3/a/b
• Should redirect to: https://smart-redirects--bacom--adobecom.hlx.page/drafts/methomas/smart-redirects-end/b/products/a?redirect_from=%2Fdrafts%2Fmethomas%2Ffolder-does-not-exist-3%2Fa%2Fb

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• fc1262d ✅ (latest)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.70%. Comparing base (94a0e5c) to head (fc1262d).

Additional details and impacted files

@@           Coverage Diff           @@
##            stage     #257   +/-   ##
=======================================
  Coverage   96.70%   96.70%           
=======================================
  Files          12       12           
  Lines        1335     1335           
=======================================
  Hits         1291     1291           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mokimo]

Cool to see this proceeding, I know it's been discussed a lot

[JasonHowellSlavin]

Should we port over the unit tests as well, or does that seem unnecessary since this PR points to the location of those tests?

[meganthecoder]

Hi @trieloff , Thanks for contributing! A few of notes:

1. I agree with @JasonHowellSlavin . If there's the possibility of needing maintenance/modifications in this repo, it should probably include the unit tests.
2. We usually link a jira ticket in the description. Is there a jira ticket or issue number associated with this feature?
3. We can contact the team who manages access or we can create the file for you. Just let us know. Our QE will need something to verify, so we'll want to get that set up before merging.

[amol-anand]

We usually link a jira ticket in the description. Is there a jira ticket or issue number associated with this feature?
https://adobe.enterprise.slack.com/archives/C0749KS9F8X

This slack thread has the entire discussion. Not sure if someone put that into a JIRA ticket.

Should we port over the unit tests as well, or does that seem unnecessary since this PR points to the location of those tests?

Like you mentioned, since we are using a different sheet (endpoint), it seems unnecessary to add unit tests for this, since the tests would need a similar test sheet for testing it out anyways.

We can contact the team who manages access or we can create the file for you. Just let us know. Our QE will need something to verify, so we'll want to get that set up before merging.

Whatever is easier for you. If someone can create the file and preview it, we can then test the functionality in this feature branch url.

[aem-code-sync]

	Page	Scores	Audits	Google
📱	/drafts/methomas/folder-does-not-exist-2/a/b
🖥️	/drafts/methomas/folder-does-not-exist-2/a/b
📱	/drafts/methomas/folder-does-not-exist-3/a/b
🖥️	/drafts/methomas/folder-does-not-exist-3/a/b
📱	/drafts/methomas/folder-does-not-exist/page-1
🖥️	/drafts/methomas/folder-does-not-exist/page-1
📱	/drafts/methomas/page-does-not-exist
🖥️	/drafts/methomas/page-does-not-exist
📱	/drafts/methomas/smart-redirects-end/a/products/b?redirect_from=%2Fdrafts%2Fmeth omas%2Ffolder-does-not-exist-2%2Fa%2Fb
🖥️	/drafts/methomas/smart-redirects-end/a/products/b?redirect_from=%2Fdrafts%2Fmeth omas%2Ffolder-does-not-exist-2%2Fa%2Fb
📱	/drafts/methomas/smart-redirects-end/b/products/a?redirect_from=%2Fdrafts%2Fmeth omas%2Ffolder-does-not-exist-3%2Fa%2Fb
🖥️	/drafts/methomas/smart-redirects-end/b/products/a?redirect_from=%2Fdrafts%2Fmeth omas%2Ffolder-does-not-exist-3%2Fa%2Fb
📱	/drafts/methomas/smart-redirects-end/page-1?redirect_from=%2Fdrafts%2Fmethomas%2 Ffolder-does-not-exist%2Fpage-1
🖥️	/drafts/methomas/smart-redirects-end/page-1?redirect_from=%2Fdrafts%2Fmethomas%2 Ffolder-does-not-exist%2Fpage-1
📱	/drafts/methomas/smart-redirects-end/page-1?redirect_from=%2Fdrafts%2Fmethomas%2 Fpage-does-not-exist
🖥️	/drafts/methomas/smart-redirects-end/page-1?redirect_from=%2Fdrafts%2Fmethomas%2 Fpage-does-not-exist

[meganthecoder]

LGTM - I've added smart-redirects.json and included some examples (based on the unit tests) in the description.

[trieloff]

Thanks for driving this forward in my absence, @amol-anand

[meganthecoder]

Release planned for Tuesday 11/5