Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

static should not fallback to master branch #415

Open
kptdobe opened this issue Nov 10, 2020 · 2 comments
Open

static should not fallback to master branch #415

kptdobe opened this issue Nov 10, 2020 · 2 comments

Comments

@kptdobe
Copy link
Contributor

kptdobe commented Nov 10, 2020

See https://github.com/adobe/helix-static/blob/master/src/static.js#L75

Required for adobe/helix-pages#531: ref might be undetermined when requesting helix-static (default branch must be used). helix-static must then:

Requires adobe/helix-resolve-git-ref/issues/299 for simplicity of the change.

@trieloff
Copy link
Contributor

Static is never called directly, so this is probably not a blocker

@kptdobe
Copy link
Contributor Author

kptdobe commented Nov 10, 2020

I think I (almost) agree. I am currently writing tests for the various overrides we may have...
I still found those direct requests to static:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants