Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for binary exp using '+' operator #1007

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add support for binary exp using '+' operator #1007

wants to merge 1 commit into from

Conversation

buuhuu
Copy link

@buuhuu buuhuu commented Oct 3, 2024 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Fixes #1006

Thanks for contributing!

tripodsan
tripodsan reviewed Oct 3, 2024
View reviewed changes
packages/helix-shared-indexer/test/index-resource.test.js
@@ -24,6 +24,9 @@ version: 1
indices:
default:
properties:
canonical:
select: main
value: path + '.html'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about directory and root? eg / or /en/ ?

tripodsan
tripodsan requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tripodsan tripodsan tripodsan requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for string concatenation by the indexer
2 participants
@buuhuu @tripodsan